Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract stylish-haskell plugin into a standalone package #1604

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Extract stylish-haskell plugin into a standalone package #1604

merged 2 commits into from
Mar 22, 2021

Conversation

berberman
Copy link
Collaborator

Following #1422

pepeiborra
pepeiborra approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@berberman berberman merged commit 5724343 into haskell:master Mar 22, 2021
@berberman berberman deleted the stylish-haskell-package branch March 22, 2021 13:49
@prikhi
Copy link
Contributor

prikhi commented Mar 25, 2021

This commit broke formatting w/ stylish-haskell for me(via coc.nvim).

On this commit, launching HLS w/ -d doesn't show PluginId "stylish-haskell" in LspArguments plugin list. On the commit before this one, it does.

@berberman
Copy link
Collaborator Author

Hi, thanks for the bug report! I just realized that cpp-options: -D was removed accidently from common stanza, so the plugin was not actually wired in HLS. I'm afraid brittany plugin had the same problem. /cc @pepeiborra

@berberman berberman mentioned this pull request Mar 25, 2021
Closed
@prikhi
Copy link
Contributor

prikhi commented Mar 25, 2021

hehe, I just submitted a PR w/ the same fix 😛
#1620

@gustavoavena gustavoavena mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berberman @prikhi @pepeiborra